Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Add mat2 Support #30364

Merged
merged 3 commits into from
Jan 20, 2025
Merged

TSL: Add mat2 Support #30364

merged 3 commits into from
Jan 20, 2025

Conversation

RenaudRohlinger
Copy link
Collaborator

Description
Support for mat2x2 was missing in the NodeBuilder, this PR adds its support.

This contribution is funded by Utsubo

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28		 336.25
78.28		 +0 B
+0 B
WebGPU 503.66
139.88		 503.8
139.96		 +140 B
+72 B
WebGPU Nodes 503.13
139.77		 503.27
139.83		 +140 B
+68 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13		 465.25
112.13		 +0 B
+0 B
WebGPU 577.44
156.5		 577.84
156.64		 +402 B
+136 B
WebGPU Nodes 532.82
146.06		 533.23
146.2		 +402 B
+138 B

@RenaudRohlinger RenaudRohlinger marked this pull request as draft January 20, 2025 12:48
@RenaudRohlinger RenaudRohlinger marked this pull request as ready for review January 20, 2025 13:00
@RenaudRohlinger RenaudRohlinger changed the title TSL: Add mat2x2 Support TSL: Add mat2 Support Jan 20, 2025
@sunag sunag added this to the r173 milestone Jan 20, 2025
@sunag sunag merged commit f4ff275 into mrdoob:dev Jan 20, 2025
12 checks passed
@RenaudRohlinger RenaudRohlinger mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
3 participants
@RenaudRohlinger @Mugen87 @sunag