Editor Bug fix: Auto reload after language changing

[pkpedram]

When language is changed user must reload the page manually.

I know this is not the best solution for this purpose but it fixes the bug for now.

I will work on a better solution later.

Please consult me for the better solution (like should I add a new signal or etc...)

Screencast.from.2025-01-20.12-00-34.webm

[Mugen87]

Please consult me for the better solution (like should I add a new signal or etc...)

I think this approach is totally fine. If we would need to trigger reloads in multiple locations, using a separate signal might be more clean. But for now this is good enough.

[pkpedram]

Please consult me for the better solution (like should I add a new signal or etc...)

I think this approach is totally fine. If we would need to trigger reloads in multiple locations, using a separate signal might be more clean. But for now this is good enough.

thank you so much ❤️
but I was thinking about a solution to not reload the page but to rerender the texts. like changing the shortcuts in setting works instantly but the language changing action doesn't
I tried this:

editor.config.setKey( 'language', value );
editor.strings = new Strings( editor.config );

it updates the strings class in editor but doesn't update the dom

I think I must dig deeper.

any ideas?

[Mugen87]

I think we would need a new signal that refreshes the entire UI which I don't think is worth implementing. Changing the app's language is normally a one-time operation per workstation so a reload shouldn't be an issue.

[pkpedram]

I think we would need a new signal that refreshes the entire UI which I don't think is worth implementing. Changing the app's language is normally a one-time operation per workstation so a reload shouldn't be an issue.

Seems fair. thank you

[ycw]

editor should autosave once so that even if users disabled autosave they won't lose their current editing after full page reload

[pkpedram]

editor should autosave once so that even if users disabled autosave they won't lose their current editing after full page reload

good point I will work on it ASAP

[ycw]

This is how editor save to IndexedDB: editor.storage.set( editor.toJSON() ), but it isn't a blocking operation, so we may update Storage#set to accept onSaved callback in the 2nd parameter, and then on UI language changed ... :

// save to IndexedDB before reloading
editor.storage.set( editor.toJSON(), () => window.location.reload() )

[pkpedram]

This is how editor save to IndexedDB: editor.storage.set( editor.toJSON() ), but it isn't a blocking operation, so we may update Storage#set to accept onSaved callback in the 2nd parameter, and then on UI language changed ... :

// save to IndexedDB before reloading
editor.storage.set( editor.toJSON(), () => window.location.reload() )

how about i work on that matter and in next step i add it to this bug fix?

[Mugen87]

@ycw Would the following work instead? Just check if autosave is enabled and if so perform a reload. The config settings can be checked via:

editor.config.getKey( 'autosave' ) === true

In this way we avoid the issue mentioned in #30363 (comment) and users can save/reload by themselves.

[ycw]

To best of my knowledge editor saves to IndexedDB is scheduled using setTimeout, where IndexedDB API is not blocking rather using callbacks. If full-page reload e.g. location.reload performs immediately it won't await setTimeout nor callbacks, so I should correct my comment #30363 (comment), no matter config of "autosave" is enabled or not, we should always save once before reloading. FWIW, for a non-simple scene, each autosave action may takes few seconds, most likely editor is still waiting for save upon page-reload in this case.

[Mugen87]

Um, maybe we should avoid the reload altogether and force a refresh of the entire UI. I don't like the side effects on the save mechanism of the current approach.

Different approach required.

[Mugen87]

Alternatively, how about adding a info message next to the language selection that says changing the language requires a restart of the editor?

[pkpedram]

Um, maybe we should avoid the reload altogether and force a refresh of the entire UI. I don't like the side effects on the save mechanism of the current approach.

my idea was that reloading is supposed to be a temp solution and then work on a UI rerender signal. I am working on it.