Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XRManager: Fix background. #30348

Merged
merged 2 commits into from
Jan 17, 2025
Merged

XRManager: Fix background. #30348

merged 2 commits into from
Jan 17, 2025

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 17, 2025

Related issue: #30346

Description

Small follow-up to fix backgrounds in XR.

@Mugen87 Mugen87 added this to the r173 milestone Jan 17, 2025
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.25
78.28		 336.25
78.28		 +0 B
+0 B
WebGPU 503.11
139.72		 503.18
139.76		 +68 B
+39 B
WebGPU Nodes 502.58
139.61		 502.65
139.65		 +68 B
+39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.25
112.13		 465.25
112.13		 +0 B
+0 B
WebGPU 576.89
156.36		 576.96
156.41		 +68 B
+44 B
WebGPU Nodes 532.28
145.92		 532.35
145.96		 +68 B
+43 B

@Mugen87 Mugen87 merged commit 5b7a017 into mrdoob:dev Jan 17, 2025
12 checks passed
@Mugen87 Mugen87 changed the title XRManager: Fix background XRManager: Fix background. Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r173
Development

Successfully merging this pull request may close these issues.
1 participant
@Mugen87