-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Fix clear alpha in WebGLBackend #30329
WebGPURenderer: Fix clear alpha in WebGLBackend #30329
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
@RenaudRohlinger There seems to be a minor issue with the
Live example: https://jsfiddle.net/obvwkyne/1/ The It does work with |
Should we just wrap this line with the if ( renderContext !== null ) {
renderContext.clearColorValue = this._clearColor;
} I would guess this PR was a fix for |
That sounds good! |
Description
This PR addresses an issue where the renderer's
clear
method does not properly clear the alpha channel whenautoClear
is set to false. Additionally, theviewport
andscissor
logic in the WebGLBackend has been refactored to align with best practices, reducing unnecessary WebGL bindings.This contribution is funded by Utsubo