-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTX2Loader: Fix .minFilter default for untranscoded compressed textures #29904
KTX2Loader: Fix .minFilter default for untranscoded compressed textures #29904
Conversation
three.js/src/renderers/webgl/WebGLTextures.js Lines 957 to 997 in 5b51d6f
TBH, I was never happy with the exception handling of I wish we could avoid |
I think we could change KTX2Loader to return three.js/examples/jsm/loaders/KTX2Loader.js Lines 299 to 311 in 19123ff
|
KTX2Loader implements three 'paths' for textures:
Basis UASTC HDR textures may take path (2) or (3) depending on device support for ASTC HDR formats, since the pre-transcode data is also valid ASTC data. In case (2), we weren't correctly setting
.minFilter
defaults for textures without mipmaps.