Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh - better error handling 2 #29790

Merged
merged 2 commits into from
Nov 5, 2024
Merged

BatchedMesh - better error handling 2 #29790

merged 2 commits into from
Nov 5, 2024

Conversation

Makio64
Copy link
Contributor

@Makio64 Makio64 commented Nov 2, 2024

Related issue: #29379

Rebase my previous PR to handle better the errors in BatchedMesh and throwing error to avoid "silent error" and let it know the devs something wrong in their code.

It's also a first step to refractor the code of BatchedMesh to make it more simple.

Copy link

github-actions bot commented Nov 2, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 692.35
171.47
692.55
171.49
+196 B
+20 B
WebGPU 822.19
221.91
822.39
221.95
+196 B
+45 B
WebGPU Nodes 821.48
221.76
821.68
221.8
+196 B
+42 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 464.89
112.3
464.89
112.3
+0 B
+0 B
WebGPU 542.77
146.84
542.77
146.84
+0 B
+0 B
WebGPU Nodes 498.71
136.59
498.71
136.59
+0 B
+0 B

@Mugen87 Mugen87 added this to the r171 milestone Nov 4, 2024
Add `THREE` namespace to messages.
@Mugen87 Mugen87 merged commit f421bff into mrdoob:dev Nov 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants