Addons: Remove SDFGeometryGenerator. #29281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM 👍 |
This was referenced Sep 22, 2024
|
😿😿😿 |
|
Sorry, we can't maintain all the code 😕 |
mrdoob
reviewed
Feb 6, 2025
| WebGLRenderTarget | ||
| } from 'three'; | ||
|
|
||
| import { surfaceNet } from './../libs/surfaceNet.js'; |
There was a problem hiding this comment.
I think we forgot to remove surfaceNet.js too?
There was a problem hiding this comment.
Indeed! It can be removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29171
Description
Another example that I suggest to remove is
webgl_geometry_sdf. When #26837 was merged, I have underestimated the dependency to GLSL andWebGLRenderer. Especially since with WebGPU you have compute shaders so something likeSDFGeometryGeneratorcould be implemented in a different way.Considering the complexity of
SDFGeometryGeneratorand that it is not common task to generate geometries from a SDF, it's best to maintainSDFGeometryGeneratorin an external repository.