Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Add GTAONode. #28844

Merged
merged 23 commits into from
Jul 11, 2024
Merged

Nodes: Add GTAONode. #28844

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e8837bb
Nodes: Add `GTAONode`.
Mugen87 Jul 10, 2024
8304474
Merge remote-tracking branch 'upstream/dev' into dev72
Mugen87 Jul 10, 2024
7d6a5dd
GTAONode: Clean up.
Mugen87 Jul 10, 2024
566e560
set derivative_uniformity diagnostic to off
sunag Jul 10, 2024
19d0c6a
GTAONode: Add internal pass with correct clear color.
Mugen87 Jul 10, 2024
7a71d73
Clean up.
Mugen87 Jul 10, 2024
b7e11a9
GTAONode: Couple of fixes.
Mugen87 Jul 10, 2024
19e35f3
GTAONode: Clean up.
Mugen87 Jul 10, 2024
8f26375
GTAONode: Fix loop.
Mugen87 Jul 10, 2024
042a6f3
GTAONode: Fix normal buffer values.
Mugen87 Jul 10, 2024
a457f03
GTAONode: Use correct camera.
Mugen87 Jul 10, 2024
cf082fb
GTAONode: Use `positionView`.
Mugen87 Jul 10, 2024
c5fd906
GTAONode: Use `transformedNormalView`.
Mugen87 Jul 10, 2024
c2109ab
Clean up.
Mugen87 Jul 11, 2024
77fa428
GTAONode: Add multiple fixes.
Mugen87 Jul 11, 2024
4f97452
GTANode: More fixes.
Mugen87 Jul 11, 2024
956b4f6
GTAONode: Use `vec4` in `getSceneUvAndDepth()`.
Mugen87 Jul 11, 2024
38ee5a3
GTAONode: Fix assignment of `ao`.
Mugen87 Jul 11, 2024
da6eaae
GTAONode: Attempt to fix `getSceneUvAndDepth()`.
Mugen87 Jul 11, 2024
6bfc769
GTAONode: Fix y-sampling.
Mugen87 Jul 11, 2024
8f2fd7e
E2E: Update screenshot.
Mugen87 Jul 11, 2024
73be1d1
Examples: Add back color space conversion.
Mugen87 Jul 11, 2024
569aa37
E2E: Add example to exception list.
Mugen87 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/webgpu_postprocessing_ao.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@
const scenePass = pass( scene, camera );
scenePass.setMRT( mrt( {
output: output,
normal: transformedNormalWorld.directionToColor()
normal: transformedNormalWorld
} ) );
postProcessing.outputColorTransform = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this just temporarily to better visually debug the shader.

Copy link
Collaborator

@sunag sunag Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could try get positionView from MRT too? like:

scenePass.setMRT( mrt( {
	output: output,
	normal: transformedNormalWorld,
	view: positionView
} ) );

const scenePassView = scenePass.getTextureNode( 'view' );

We could find ways to optimize them too...

Copy link
Collaborator

@sunag sunag Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cameraProjectionMatrixInverse inside a QuadMesh.render()( PostProcessing ) it will use the current camera OrthographicCamera and not the camera used in pass().

Copy link
Collaborator Author

@Mugen87 Mugen87 Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, using positionView and the correct camera fixes the image!

I want to understand why the inline computation of positionView fails. I think this is related to the different clip space of WebGPU but I'm still not sure.

const scenePassColor = scenePass.getTextureNode( 'output' );
const scenePassNormal = scenePass.getTextureNode( 'normal' );
const scenePassDepth = scenePass.getTextureNode( 'depth' );
Expand Down
Loading