WebGPURenderer: Add snapshot facility, record scene pass as a RenderBundle for reuse, #26983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
and reuse if present.
linbingquan
reviewed
Nov 18, 2023
| @@ -60,9 +63,11 @@ | |||
| scene = new THREE.Scene(); | |||
| scene.fogNode = rangeFog( color( 0x0000ff ), 1500, 2100 ); | |||
|
|
|||
| // enable static mode | |||
| scene.false = true; | |||
There was a problem hiding this comment.
Should be scene.static = true ?
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26876
First pass at a snapshot facility for comment. Only lightly tested.
Adds:
renderer.createSnapshot() which instructs the next call to renderer.render() to save the render pass as a bundle for reuse.
renderer.destroySnapshot() which removes a snapshot if present.
TODO:
This assumes rendering to screen only, snapshot needs attaching to renderContextData rather than the backend.