Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: export the class GLTFParser #26301

Closed
wants to merge 1 commit into from

Conversation

rwjCxgsy
Copy link

Description

Sometime, Our databuffer is encrypted, so we need decrypt it before parse data buffer

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 21, 2023

It has already been discussed in #24764 whether GLTFParser should be exposed or not.

One conclusion was that GLTFParser was designed for internal use only. When it is exposed and thus part of the public API, it makes maintenance and refactoring more complicated.

The original issue of #24764 could be fixed by enhancing GLTFLoader.parse() so it was not necessary for the OP to use the parser on app level anymore.

Couldn't you decrypt your data before calling GLTFLoader.parse()?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 26, 2023

Closing due to lack of feedback.

@Mugen87 Mugen87 closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants