Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer E2E test: Use new headless mode #25982

Merged
merged 7 commits into from
Jun 12, 2023
Merged

Puppeteer E2E test: Use new headless mode #25982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46c3d67
Puppeteer E2E test: Use `new` headless mode
LeviPesin May 3, 2023
d77450c
Update
LeviPesin May 3, 2023
7c821ce
Show platform + test
LeviPesin May 3, 2023
93b8bf3
Return exceptions
LeviPesin May 4, 2023
2653793
Merge branch 'dev' into update-to-new-headless
LeviPesin Jun 11, 2023
4e7792b
WebXR isn't determinstic?
LeviPesin Jun 11, 2023
79ea756
Fix example name
LeviPesin Jun 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/screenshots/games_fps.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgl_geometry_extrude_shapes.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgl_interactive_lines.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgl_loader_collada_kinematics.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgl_loader_ldraw.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified examples/screenshots/webgl_modifier_simplifier.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 25 additions & 13 deletions test/e2e/puppeteer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,26 +42,36 @@ const parseTime = 6; // 6 seconds per megabyte

const exceptionList = [

// video tag not deterministic enough
// video tag isn't deterministic enough?
'css3d_youtube',
'webgl_materials_video',
'webgl_video_kinect',
'webgl_video_panorama_equirectangular',
'webxr_vr_video',

'webaudio_visualizer', // audio can't be analyzed without proper audio hook

'webxr_ar_lighting', // webxr
// WebXR also isn't determinstic enough?
'webxr_ar_lighting',
'webxr_vr_sandbox',
'webxr_vr_video',
'webxr_xr_ballshooter',

'webgl_worker_offscreencanvas', // in a worker, not robust

// Windows-Linux text rendering differences
// TODO: Fix these by setting a font in Puppeteer -- this can also fix a bunch of 0.1%-0.2% examples
// TODO: Fix these by e.g. disabling text rendering altogether -- this can also fix a bunch of 0.1%-0.2% examples
'css3d_periodictable',
'misc_controls_pointerlock',
'misc_uv_tests',
'webgl_camera_logarithmicdepthbuffer',
'webgl_effects_ascii',
'webgl_geometry_extrude_shapes',
'webgl_interactive_lines',
'webgl_loader_collada_kinematics',
'webgl_loader_ldraw',
'webgl_loader_pdb',
'webgl_modifier_simplifier',
'webgl_multiple_canvases_circle',
'webgl_multiple_elements_text',

// Unknown
Expand Down Expand Up @@ -149,7 +159,7 @@ console.red = msg => console.log( chalk.red( msg ) );
console.yellow = msg => console.log( chalk.yellow( msg ) );
console.green = msg => console.log( chalk.green( msg ) );

let browser;
let browser, platform;

/* Launch server */

Expand Down Expand Up @@ -221,7 +231,7 @@ async function main() {

browser = await puppeteer.launch( {
executablePath,
headless: ! process.env.VISIBLE,
headless: process.env.VISIBLE ? false : 'new',
args: flags,
defaultViewport: viewport,
handleSIGINT: false,
Expand Down Expand Up @@ -290,6 +300,8 @@ async function downloadLatestChromium() {

const browserFetcher = new BrowserFetcher( { path: 'test/e2e/chromium' } );

platform = browserFetcher.platform();

let revisionInfo = browserFetcher.revisionInfo( chromiumRevision );
if ( revisionInfo.local === true ) {

Expand All @@ -302,7 +314,7 @@ async function downloadLatestChromium() {
console.log( 'Downloaded.' );

}
console.log( `Using Chromium r${ chromiumRevision } (${ revisionInfo.url }), stable channel on ${ browserFetcher.platform() }` );
console.log( `Using Chromium r${ chromiumRevision } (${ revisionInfo.url }), stable channel on ${ platform }` );
return revisionInfo;

}
Expand Down Expand Up @@ -539,7 +551,7 @@ async function makeAttempt( pages, failedScreenshots, cleanPage, isMakeScreensho

} catch {

await screenshot.writeAsync( `test/e2e/output-screenshots/${ file }-actual.jpg` );
await screenshot.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-actual.jpg` );
throw new Error( `Screenshot does not exist: ${ file }` );

}
Expand All @@ -558,8 +570,8 @@ async function makeAttempt( pages, failedScreenshots, cleanPage, isMakeScreensho

} catch {

await screenshot.writeAsync( `test/e2e/output-screenshots/${ file }-actual.jpg` );
await expected.writeAsync( `test/e2e/output-screenshots/${ file }-expected.jpg` );
await screenshot.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-actual.jpg` );
await expected.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-expected.jpg` );
throw new Error( `Image sizes does not match in file: ${ file }` );

}
Expand All @@ -574,9 +586,9 @@ async function makeAttempt( pages, failedScreenshots, cleanPage, isMakeScreensho

} else {

await screenshot.writeAsync( `test/e2e/output-screenshots/${ file }-actual.jpg` );
await expected.writeAsync( `test/e2e/output-screenshots/${ file }-expected.jpg` );
await diff.writeAsync( `test/e2e/output-screenshots/${ file }-diff.jpg` );
await screenshot.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-actual.jpg` );
await expected.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-expected.jpg` );
await diff.writeAsync( `test/e2e/output-screenshots/${ platform }-${ file }-diff.jpg` );
throw new Error( `Diff wrong in ${ differentPixels.toFixed( 1 ) }% of pixels in file: ${ file }` );

}
Expand Down