-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer E2E test: Use new
headless mode
#25979
Conversation
|
I think this is ready to merge now. |
I'm afraid this is the only way to fix the text rendering inconsistences without adding like 20 more examples to the exception list -- in addition to those before this PR changing to the new headless mode adds like 5 more. |
Uhh... Is there any other side effect you have not disclosed in this PR? |
I can see many other broken screenshots... Why do we need to support the new headless mode if it's breaking things and not fixing anything? |
This PR has two things:
2 is so not because the new headless mode introduces the issue, but rather because it makes it more severe. I can revert the text-related changes and just add more examples to the exceptions then. |
Do all the OSes have the text rendering issue? |
This commit didn't revert the previous ones 🤦♂️ |
The issue is the difference of text rendering between all three OSes. |
|
Then... How about we just test in one OS as we used to? I have yet to see any benefit in testing on all OSes... |
Related issue:
Description
Let's see how this works...