Remove CSS2DObject from CSS2DRender when Object3D is Removed #25083
Conversation
doppl3r
changed the title
| @@ -18,6 +18,17 @@ class CSS2DObject extends Object3D { | |||
| this.element.style.userSelect = 'none'; | |||
|
|
|||
| this.element.setAttribute( 'draggable', false ); | |||
|
|
|||
| const _this = this; | |||
| this.addEventListener( 'added', function() { | |||
There was a problem hiding this comment.
I'm not sure this is the right fix for the problem.
I wonder if it wouldn't be better to solve this issue on Object3D level. Meaning when a 3D object is added or removed to/from the scene graph, descendants receive an event as well since they are indirectly affected by this operation.
There was a problem hiding this comment.
I believe having this particular event logic in the CSS2DObject level provides a unique solution for objects that also contain HTML DOM references.
CSS2DObject types do not have descendants, so it makes sense to require event listeners to their parent rather than assigning events externally.
There was a problem hiding this comment.
CSS2DObject types do not have descendants
Um, I don't think this assumptions is correct.
There was a problem hiding this comment.
You are right, my assumption was not true. I tried nesting a CSS2DObject within another CSS2DObject and they render HTML on top of each other (not pretty, but still optional). The solution I provided in this PR still work when ancestors invoke clear() or removeFromParent().
Do you have any pseudo code in mind for adding events to descendants within the Object3D class?
|
Closing. This isn't the right fix for the issue. We should reconsider to thoughts raised in #22416. The issue in |
Description
The Problem: When Object3D objects are removed, their child CSS2DObject types are not removed from the CSS2DRenderer.
The Solution: CSS2DObject types will now be removed when the parent Object3D type is removed. The CSS2DObject "removed" event is safely invoked after it is added to the parent Object3D.
Use cases: