-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer E2E test: many changes #24109
Conversation
…hree.js-1 into puppeteer-fix-webgpu
Seems like on Linux WebGPU can be enabled by launching Chrome with |
But it still does not work on Windows... |
Hm, should I split my changes to the lint test (there are not too much of them, actually) to a separate PR? |
Hmm, yeah. It'd be great if you can do a different PR for the lint fixes if possible. |
I've decided to split this PR into multiple small PRs (both for easier resolving conflicts and making easier to merge), for example:
Will file them soon. (Closing this PR.) |
Related issue: -
Description
Many changes to the Puppeteer E2E test and tests in general (e.g. lint test).
Removed pageSize code - I think it does not need such fine-tuning, and it actually never worked - the timeout passed to setTimeout was negative in most cases because Math.min was used there instead of Math.max,TODO:
Possibly remove the attempts entirely and instead do one attempt but with large timeouts? This can possibly break if an error unrelated to the timeouts happens,I actually think this is not needed - errors happen rarely, so the second attempt would be rarely needed, so it would not result in slow tests,Investigate whether GitHub Actions allow to autosupply Chromium to the E2E test (so that it would not be required for it to download),(is not needed, GitHub network is very fast)Remove on-the-fly changing ofbuild/three.module.js
(this requires regenerating most of the screenshots for some reason, I think?),Current problems:
Fix WebGPU on Linux,(the problem is not in Linux, but in GitHub Actions)fromSurface: false
screenshoting,window.TESTING
,Refactor idleTime and parseTime system (revert to one that was before and add per-example custom timeouts?).(is not needed)output-screenshots/
directory from tests on GitHub.Strange errors:
(the following errors happen rarely)