Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeEditor: Add missing position entries #23310

Merged
merged 1 commit into from
Jan 25, 2022
Merged

NodeEditor: Add missing position entries #23310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/jsm/node-editor/accessors/NormalEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export class NormalEditor extends BaseNode {
const optionsField = new SelectInput( [
{ name: 'Local', value: NormalNode.LOCAL },
{ name: 'World', value: NormalNode.WORLD },
{ name: 'View', value: NormalNode.VIEW }
{ name: 'View', value: NormalNode.VIEW },
{ name: 'Geometry', value: NormalNode.GEOMETRY },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can remove it , and others at the end of the array.

], NormalNode.LOCAL ).onChange( () => {

node.scope = optionsField.getValue();
Expand Down
3 changes: 2 additions & 1 deletion examples/jsm/node-editor/accessors/PositionEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ export class PositionEditor extends BaseNode {
const optionsField = new SelectInput( [
{ name: 'Local', value: PositionNode.LOCAL },
{ name: 'World', value: PositionNode.WORLD },
{ name: 'View', value: PositionNode.VIEW }
{ name: 'View', value: PositionNode.VIEW },
{ name: 'ViewDirection', value: PositionNode.VIEW_DIRECTION },
], PositionNode.LOCAL ).onChange( () => {

node.scope = optionsField.getValue();
Expand Down
11 changes: 9 additions & 2 deletions examples/jsm/node-editor/math/TrigonometryEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,19 @@ export class TrigonometryEditor extends BaseNode {

const node = new MathNode( MathNode.SIN, DEFAULT_VALUE );

super( 'Trigonometry', 1, node, 175 );
super( 'Angle / Trigonometry', 1, node, 220 );
Copy link
Collaborator

@sunag sunag Jan 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I had separated Angle from Trigonometry in Editor. @mrdoob Some suggestion?

Copy link
Owner

@mrdoob mrdoob Jan 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean having a node that mostly converts radians to degrees?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, yes. A Node in Editor only for it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that sounds good yes 👍


const optionsField = new SelectInput( [
{ name: 'Radian', value: MathNode.RAD },
{ name: 'Degree', value: MathNode.DEG },

{ name: 'Sin', value: MathNode.SIN },
{ name: 'Cos', value: MathNode.COS },
{ name: 'Tan', value: MathNode.TAN }
{ name: 'Tan', value: MathNode.TAN },

{ name: 'asin', value: MathNode.ASIN },
{ name: 'acos', value: MathNode.ACOS },
{ name: 'atan', value: MathNode.ATAN },
], MathNode.SIN ).onChange( () => {

node.method = optionsField.getValue();
Expand Down