CSS2DObject and CSS3DObject: Remove broken generics and make renderer parameter unknown #18520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliendargelos
changed the title
|
Thanks! |
|
Does this deserve pushing the npm package to |
|
This was quite a nonsense and will cause type errors on existing typescript code that uses render callbacks: three.js/src/core/Object3D.d.ts Lines 156 to 157 in 19ae971 So I think the fix should be pushed |
|
Done! |
|
Well, that's why I'm not a fan of static typing^^. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18518 (comment)