Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onBeforeRender and onAfterRender callbacks in CSS3DRenderer #18502

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

juliendargelos
Copy link
Contributor

No description provided.

@mrdoob mrdoob added this to the r113 milestone Jan 28, 2020
@mrdoob mrdoob merged commit 4012119 into mrdoob:dev Jan 28, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2020

Thanks!

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 29, 2020

@juliendargelos If you like, you can also implement this change in CSS2DRenderer 👍

@juliendargelos
Copy link
Contributor Author

Yes I'll do it, I also have to update CSS3DObject typescript declarations to overwrite signatures from Object3D:

/**
* Calls before rendering object
*/
onBeforeRender: (
renderer: WebGLRenderer,
scene: Scene,
camera: Camera,
geometry: Geometry | BufferGeometry,
material: Material,
group: Group
) => void;
/**
* Calls after rendering object
*/
onAfterRender: (
renderer: WebGLRenderer,
scene: Scene,
camera: Camera,
geometry: Geometry | BufferGeometry,
material: Material,
group: Group
) => void;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants