Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Fix specular-glossiness material. #18272

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 30, 2019

@mrdoob mrdoob added this to the r113 milestone Dec 31, 2019
@mrdoob mrdoob requested a review from donmccurdy December 31, 2019 00:05
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 31, 2019

Prod: https://threejs.org/examples/webgl_loader_gltf_extensions.html
PR: https://raw.githack.com/Mugen87/three.js/dev26/examples/webgl_loader_gltf_extensions.html

This is how the boom box looks in prod now:

image

It also logs the warning:

three.module.js:18258 THREE.WebGLProgram: gl.getProgramInfoLog() WARNING: Output of vertex shader 'vTangent' not read by fragment shader

After this change:

image

And the warning is gone, too.

@mrdoob mrdoob merged commit eb4e237 into mrdoob:dev Dec 31, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 31, 2019

Thanks!

Mugen87 referenced this pull request in toji/xr-dinosaurs Jan 3, 2020
Copied new shader fragment from mrdoob/three.js#18265
which reduces the amount of banding on some materials with certain GPUs.

I expect that the next Three.js roll will include this fix as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants