Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math: Rename to MathUtils. #18270

Merged
merged 3 commits into from
Jan 1, 2020
Merged

Math: Rename to MathUtils. #18270

merged 3 commits into from
Jan 1, 2020

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Dec 30, 2019 •
edited
Loading

Fixed #9399.

Because of export { MathUtils as Math }; in Three.Legacy.js, the change is backwards-compatible for now.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 30, 2019 •
edited
Loading

BTW: Travis is failing right now since the build files do not yet reflect the change.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Dec 30, 2019

Updated the builds now so it's easier to see Travis and lgtm errors.

@Mugen87 Mugen87 added this to the r113 milestone Dec 31, 2019
@mrdoob mrdoob merged commit 9eb4fb3 into mrdoob:dev Jan 1, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 1, 2020

Thanks!

@msemtd msemtd mentioned this pull request Sep 3, 2020
Merged
@juunini juunini mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r113
Development

Successfully merging this pull request may close these issues.

THREE.Math is now _Math, probably need a better name that doesn't conflict with built-in Math.
2 participants
@Mugen87 @mrdoob