-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLRenderer: Support custom painter sort functions. #16909
WebGLRenderer: Support custom painter sort functions. #16909
Conversation
Thank you @Mugen87 Do you want me to provide the documentation? Should I use this feature branch to do so? About the |
No, it's manually maintained.
Yes, that's fine. Adding docs would be great. |
@Mugen87 I don't mean to push it but is there an ETA? |
I'm afraid you have to wait for @mrdoob's review 😇 |
@WestLangley I've fixed all of the issues above on my local branch and can push if you want me to. |
I think that would be good 👍 |
Please don't push build files. It seems they sneaked in with the last commit. |
@Mugen87 it seems I have conflicts, sorry about that. |
Do this on your system:
Then undo the changes to the build files and make a new commit. (Force) push it like so:
|
c40d465
to
7839814
Compare
Thanks! |
As discussed here I've created a PR that enables support for dynamic sort functions.