Editor: Add RectAreaLight #16251
Editor: Add RectAreaLight #16251
Conversation
|
It seems the PR has a merge conflict... |
|
To get |
Temdog007
force-pushed
the
editor/RectAreaLight
branch
from
9cd618a to
38a5d8e
Compare
Temdog007
force-pushed
the
editor/RectAreaLight
branch
from
38a5d8e to
2704ce2
Compare
|
|
||
| // RectAreaLightHelper was designed to work only if it is a child of its light. | ||
| // Since that cannot be done in the edtior, the updateMatrixWorld function is overwritten to apply the matrix calculations to the light. | ||
| THREE.RectAreaLightHelper.prototype.updateMatrixWorld = function () { |
There was a problem hiding this comment.
RectAreaLightHelper was designed to work only if it is a child of its light.
@mrdoob @WestLangley Do you know the reasons for this? I've checked the history of RectAreaLightHelper but found nothing.
Other users have already run into issues because of how RectAreaLightHelper works (see https://discourse.threejs.org/t/rectarealight-remaining-at-0-0-0/10057). I think it would be less confusing if adding the helper to the light is not required (similar to e.g. PointLightHelper). This modification here would not be necessary then.
There was a problem hiding this comment.
Do you know the reasons for this? I've checked the history of RectAreaLightHelper but found nothing.
I expect all light helpers will be changed to match the behavior of RectAreaLightHelper once lights are controlled by the quaternion.
|
Since the editor is now module based (#18201), a lot of code has changed. It's better to implement this feature from scratch. |
See #16234