GLTFLoader: Remove dependency on 'THREE.DRACOLoader' global #15943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back #15177.
I think it's better to avoid a dependency on the global
THREE.DRACOLoader
namespace. It will be an issue for our ES module refactoring (GLTFLoader can accept a DRACOLoader instance as a parameter, but doesn't depend on it directly) and it prevents users from providing a custom DRACOLoader instance, per #15249 and google/model-viewer#72.Fortunately, an easy workaround for users is to call
THREE.DRACOLoader.getDecoderModule()
in their own code when they know Draco is needed, which actually performs even better (it doesn't have to wait for the JSON header). I've documented this accordingly./cc @TyLindberg