Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Added serve.json #14210

Closed
wants to merge 1 commit into from
Closed

Dev: Added serve.json #14210

wants to merge 1 commit into from

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 3, 2018

This new config file is necessary in order to ensure that the documentation still works correctly with serve > 7.0.0. More information about the option right here: https://github.com/zeit/serve-handler#cleanurls-booleanarray

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 3, 2018

Maybe it's a good idea to cherry-pick this PR to master. Just to avoid confusion.

@mrdoob
Copy link
Owner

mrdoob commented Jun 5, 2018

Hmm... Not a big fan of polluting the root of the repo. Do they support different folders?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 5, 2018

I've found no other way according to their docs. Opened an issue to see what the developers recommend.

@donmccurdy
Copy link
Collaborator

Thanks — added a comment as well. I like serve quite a bit, and am confused why they changed that default.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 10, 2018

Closing in favor of #14264

@Mugen87 Mugen87 closed this Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants