Rough update to KHR_lights support to match current spec #13341

MiiBond · 2018-02-15T23:12:07Z

Updated to match current spec.
KhronosGroup/glTF#1223

donmccurdy · 2018-02-16T17:20:16Z

For the renderer light settings, I think it's ok just to add:

// The KHR_lights extension should use physically-correct lighting mode.
renderer.physicallyCorrectLights = true;

... to the entire example, no need to turn it on/off when the extension is selected.

mrdoob · 2018-03-03T03:57:25Z

@donmccurdy looks good?

donmccurdy · 2018-03-03T04:46:04Z

@mrdoob we should plan this one for r92, more likely, it will about a week before we've answered a couple last questions about this extension (partly my fault on that 😅).

donmccurdy · 2018-03-03T05:09:33Z

@MiiBond I think i've come around for having ambient lights on the scene... do you want to include that change in this PR?

MiiBond · 2018-03-03T06:02:45Z

@donmccurdy I think this pull request handles the ambient light on the scene, doesn't it? Or did you mean something else?
This pull request doesn't attempt to limit the number of ambient lights or prevent them from being on a node or anything but I gather we're not relying too much on the loader validating the glTF.

MiiBond · 2018-03-03T06:04:00Z

It did just occur to me that the handling of direction for SpotLight and DirectionalLight are wrong. In three.js, the direction doesn't come from the matrix, right? It's dependent on the position and target of the light?

donmccurdy · 2018-03-03T06:23:35Z

I think this pull request handles the ambient light on the scene, doesn't it? Or did you mean something else?

Oh! My mistake, I'd expected to see something in your PR checking for a light in the scene, but I guess that part was already here.

In three.js, the direction doesn't come from the matrix, right? It's dependent on the position and target of the light?

Hmm yeah. If we want a spotlight to point correctly in a direction relative to its local transform, even if the node is animated, perhaps we do this:

light.target.position.set( 0, 0, 1 );
light.add( light.target );

MiiBond · 2018-03-07T18:02:23Z

@donmccurdy Yeah, I think that works.
I've updated the pull request.

mrdoob · 2018-03-08T00:58:56Z

Can we replace the current Monster.gltf model with the one with a light instead of having 2 Monster.gltf?

MiiBond · 2018-03-08T01:25:22Z

@mrdoob I just followed the convention already being used and just added a new one for the new extension. There are already 5 other copies of monster.gltf; one for each extension.

mrdoob · 2018-03-08T02:24:51Z

I see...

donmccurdy · 2018-03-08T05:06:23Z

We could drop glTF-Embedded/Monster/*, to just keep the current count.

For a future cleanup PR, I don't think we need to have all of glTF, glTF-Embedded, and glTF-Binary for every model — has been a long time since we've seen any bugs related to container structure. Keeping extensions around that add functionality like pbrSpecularGlossiness and lights seems more important.

mrdoob · 2018-04-04T21:14:44Z

/ping @donmccurdy

donmccurdy · 2018-04-04T22:44:47Z

examples/webgl_loader_gltf_extensions.html

@@ -202,14 +202,13 @@
 					var ambient = new THREE.AmbientLight( 0x222222 );
 					scene.add( ambient );

-					var directionalLight = new THREE.DirectionalLight( 0xdddddd );
+					var directionalLight = new THREE.DirectionalLight( 0xdddddd, 4 );


Why the intensity increase here? Related to physicallyCorrectLights setting?

I think so, yeah. That was a while ago...

donmccurdy

Looks good — We can remove some other example models in another PR.

mrdoob · 2018-04-04T23:54:12Z

examples/js/loaders/GLTFLoader.js

@@ -261,7 +262,14 @@ THREE.GLTFLoader = ( function () {

 				case 'spot':
 					lightNode = new THREE.SpotLight( color );
-					lightNode.position.set( 0, 0, 1 );
+					// Handle spotlight properties.
+					var spot = light.spot || {};


How about doing this instead?

var spot = light.spot || { innerConeAngle: 0, outerConeAngle: Math.PI / 4.0 }; lightNode.angle = spot.outerConeAngle; lightNode.penumbra = 1.0 - ( spot.innerConeAngle / spot.outerConeAngle ); lightNode.target.position.set( 0, 0, 1 ); lightNode.add( lightNode.target );

innerConeAngle and outerConeAngle are not required to be present, so their default values must be set independently. @MiiBond is the spot property required? Perhaps:

light.spot = light.spot || {}; light.spot.innerConeAngle = light.spot.innerConeAngle !== undefined ? light.spot.innerConeAngle : 0; light.spot.outerConeAngle = light.spot.innerConeAngle !== undefined ? light.spot.innerConeAngle : Math.PI / 4.0; // ...

spot isn't required, no.

I'm not sure I follow what you're suggesting with your change. Are you just suggesting to get rid of the variable declarations within the case statement?

I think that is the idea; i'm happy with or without that change.

mrdoob · 2018-04-04T23:54:52Z

examples/js/loaders/GLTFLoader.js

+					var outerConeAngle = spot.outerConeAngle !== undefined ? spot.outerConeAngle : Math.PI / 4.0;
+					lightNode.angle = outerConeAngle;
+					lightNode.penumbra = 1.0 - innerConeAngle / outerConeAngle;
+					lightNode.target.position.set( 0, 0, 1 );


The target of a spot is 0, 0, 1 by default?

The local direction of the glTF light is always +Z; the only way to rotate it is by rotating the object or its parents in the scene graph.

mrdoob · 2018-04-06T02:58:12Z

Thanks!

Rough update to KHR_lights support to match current spec

e362e29

mrdoob requested a review from donmccurdy February 16, 2018 01:53

mrdoob added this to the r91 milestone Feb 16, 2018

MiiBond added 2 commits February 16, 2018 08:42

Merge branch 'dev' of github.com:mrdoob/three.js into gltf_khr_lights_v2

6c5da91

Minor adjustment

317870b

MiiBond mentioned this pull request Feb 16, 2018

glTF 2.0: New KHR_lights extension KhronosGroup/glTF#945

Closed

Add physicallyCorrectLights = true

b9d316d

mrdoob modified the milestones: r91, r92 Mar 3, 2018

Add target setup for directional-spot lights when loading from glTF

f22daf7

Merge branch 'dev' of github.com:mrdoob/three.js into gltf_khr_lights_v2

9fa3edc

donmccurdy reviewed Apr 4, 2018

View reviewed changes

donmccurdy approved these changes Apr 4, 2018

View reviewed changes

mrdoob reviewed Apr 4, 2018

View reviewed changes

minor adjustment

f45894b

mrdoob merged commit b69d7c7 into mrdoob:dev Apr 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rough update to KHR_lights support to match current spec #13341

Rough update to KHR_lights support to match current spec #13341

MiiBond commented Feb 15, 2018

donmccurdy commented Feb 16, 2018

mrdoob commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

MiiBond commented Mar 3, 2018

MiiBond commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

MiiBond commented Mar 7, 2018

mrdoob commented Mar 8, 2018

MiiBond commented Mar 8, 2018

mrdoob commented Mar 8, 2018

donmccurdy commented Mar 8, 2018

mrdoob commented Apr 4, 2018

donmccurdy Apr 4, 2018 •

edited

Loading

MiiBond Apr 4, 2018

donmccurdy left a comment

mrdoob Apr 4, 2018

donmccurdy Apr 5, 2018

MiiBond Apr 5, 2018

donmccurdy Apr 5, 2018

mrdoob Apr 4, 2018

donmccurdy Apr 5, 2018

mrdoob commented Apr 6, 2018

Rough update to KHR_lights support to match current spec #13341

Rough update to KHR_lights support to match current spec #13341

Conversation

MiiBond commented Feb 15, 2018

donmccurdy commented Feb 16, 2018

mrdoob commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

MiiBond commented Mar 3, 2018

MiiBond commented Mar 3, 2018

donmccurdy commented Mar 3, 2018

MiiBond commented Mar 7, 2018

mrdoob commented Mar 8, 2018

MiiBond commented Mar 8, 2018

mrdoob commented Mar 8, 2018

donmccurdy commented Mar 8, 2018

mrdoob commented Apr 4, 2018

donmccurdy Apr 4, 2018 • edited Loading

Choose a reason for hiding this comment

MiiBond Apr 4, 2018

Choose a reason for hiding this comment

donmccurdy left a comment

Choose a reason for hiding this comment

mrdoob Apr 4, 2018

Choose a reason for hiding this comment

donmccurdy Apr 5, 2018

Choose a reason for hiding this comment

MiiBond Apr 5, 2018

Choose a reason for hiding this comment

donmccurdy Apr 5, 2018

Choose a reason for hiding this comment

mrdoob Apr 4, 2018

Choose a reason for hiding this comment

donmccurdy Apr 5, 2018

Choose a reason for hiding this comment

mrdoob commented Apr 6, 2018

donmccurdy Apr 4, 2018 •

edited

Loading