Move WEBGL_CONSTANTS and THREE_TO_WEBGL constants out from GLTFExporter and GLTFLoader #11978

fernandojsg · 2017-08-18T08:45:21Z

Not so happy with the name THREEToWebGL.js and WebGLToTHREE any suggestions? :)
I believe most of the mappings from WebGLUtils (https://github.com/mrdoob/three.js/blob/dev/src/renderers/webgl/WebGLUtils.js#L13-L35 ...) could be replaced by this mappings constants as I find it more handy to use than need to create a WebGLUtils instance with a renderer and extensions. Maybe in another PR we could just reuse the constants mapping on the WebGLUtils function and just leave the code related to extensions there?

takahirox · 2017-08-18T09:36:44Z

The variables are glTF specific, correct?
I'm feeling like the variable names (of file names) should indicate they're for glTF.
So add prefix GLTF like GLTF_WEBGL_CONSTANTS?

fernandojsg · 2017-08-18T09:39:13Z

@takahirox these are not gltf specific, these are generic WEBGL constants (https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Constants) that can be used in other places not just in the gltf loader.
And the other files are just conversions between THREEjs constants to and from WEBGL constants.

takahirox · 2017-08-18T09:42:27Z

Oops, I didn't know that they're equal to gl.*, thanks!

fernandojsg · 2017-08-18T09:52:54Z

Yes, the point was to avoid sending a renderer's context to the exporter (As discussed in #11964)

takahirox · 2017-08-18T11:12:47Z

I see I see, that makes sense!

mrdoob · 2017-08-21T20:37:44Z

src/Three.js

@@ -156,5 +156,8 @@ export { Curve } from './extras/core/Curve.js';
 export { ShapeUtils } from './extras/ShapeUtils.js';
 export { SceneUtils } from './extras/SceneUtils.js';
 export { WebGLUtils } from './renderers/webgl/WebGLUtils.js';
+export { WEBGL_CONSTANTS } from './renderers/webgl/WebGLConstants.js';


I think I would keep this as:

export { WebGLConstants } from './renderers/webgl/WebGLConstants.js';

Also, I think I would add a fromGL() and toGL() methods that does the THREEToWebGL and WebGLToTHREE` conversions. Just to keep everything in one file.

@mrdoob Do you mean including and exporting fromGL, toGL and WebGLConstants from WebGLConstants.js?

If that's the case, maybe rename the export to constants so you could use it as:

THREE.WebGLConstants.constants.POINTS THREE.WebGLConstants.fromGL(gl.POINTS) THREE.WebGLConstants.toGL(THREE.FrontSide)

I like this API style better.

var constants = new THREE.WebGLConstants(); constants.POINTS; constants.fromGL(gl.POINTS); constants.toGL(THREE.FrontSide);

But I'm not 100%. Maybe fromGL() and toGL() could go on WebGLUtils instead.

I don't really like the need to create a new instance just to query a constant. I would prefer to access it directly:

THREE.WebGLConstants.POINTS;

The same for the fromGL and toGL that I believe too that they should be part of WebGLUtils

THREE.WebGLUtils.fromGL(gl.POINTS) THREE.WebGLUtils.toGL(THREE.FrontSide)

@mrdoob I've updated WebGLUtils and WebGLConstants (still WIP) but to show a possible implementation of this last option

Eventually convert and toGL will become the same function. In fact right now with the current modifications convert doesn't need a gl context anymore just the extensions dependency.

fernandojsg · 2017-08-22T11:43:30Z

@mrdoob I've updated the WebGLUtils to export toGL and fromGL. I've replaced convert by toGL in the rest of the code as it was just duplicated code and the need to create a new instance and the dependencies from a gl context and extensions are not needed anymore as we're just exposing constants that we've in the WebGLConstants file.
I didn't change yet the GLTFLoader/Exporter until you'd validate the code.

Taking a look at constants.js, I believe I could export the WebGLConstants in a similar way instead of just exporting the whole object if you prefer so.

takahirox · 2017-08-23T21:58:01Z

Will this PR be merged soon?
I'm making PRs using constants.
I'll wait for this PR being merged if it'll be soon.

fernandojsg · 2017-08-23T22:44:31Z

Rebased!
I export WebGLUtils object that contains the toGL and fromGL functions that are basically just an alias to access to the mapping dictionaries.
I believe it's more intuitive and easy to use this way instead of creating a new instance of the object everytime you need to use, the same way as we don't do var math = new Math(); math.clamp(x) every time we need to use a math function.
@mrdoob friendly bump 👋 👼

fernandojsg · 2017-08-24T20:39:11Z

I'm not sure why the lgtm tests are failing they were ok I did a rebase and they seem to be broken since then ¯_(ツ)_/¯

takahirox · 2017-08-30T14:57:04Z

lgtm tests are fine now 😄

fernandojsg · 2017-08-30T15:24:14Z

@takahirox yep, I just rebased it and pushed it again :)

takahirox · 2017-10-16T22:22:23Z

When will we merge this PR?

mrdoob · 2017-10-18T19:16:16Z

examples/js/exporters/GLTFExporter.js

-				minFilter: THREE_TO_WEBGL[ map.minFilter ],
-				wrapS: THREE_TO_WEBGL[ map.wrapS ],
-				wrapT: THREE_TO_WEBGL[ map.wrapT ]
+				magFilter: THREE.WebGLUtils.toGL[ map.magFilter ],


toGL is a function 😅

mrdoob · 2017-10-18T19:18:16Z

examples/js/loaders/GLTFLoader.js

@@ -1381,7 +1264,7 @@ THREE.GLTFLoader = ( function () {
 			return parser.getDependency( 'bufferView', accessor.bufferView ).then( function ( bufferView ) {

 				var itemSize = WEBGL_TYPE_SIZES[ accessor.type ];
-				var TypedArray = WEBGL_COMPONENT_TYPES[ accessor.componentType ];
+				var TypedArray = THREE.WEBGL_TO_THREE[ accessor.componentType ];


Wouldn't it be better to use the same approach everywhere? THREE.WebGLUtils.fromGL()...

mrdoob · 2017-10-18T19:18:56Z

src/renderers/WebGLRenderer.js

@@ -31,7 +31,7 @@ import { Vector3 } from '../math/Vector3.js';
 import { WebGLClipping } from './webgl/WebGLClipping.js';
 import { Frustum } from '../math/Frustum.js';
 import { Vector4 } from '../math/Vector4.js';
-import { WebGLUtils } from './webgl/WebGLUtils.js';
+import { WebGLUtils } from './webgl/WebGLUtils';


Lets keep WebGLUtils.js.

mrdoob · 2017-10-18T19:20:00Z

src/renderers/webgl/WebGLUtils.js

+//------------------------------------------------------------------------------
+var THREE_TO_WEBGL = {
+
+	[ Constants.NearestFilter ]: WebGLConstants.NEAREST,


Was not aware of this [ variable ] thing. Is it well supported?

It's ES6 computed literals. I thought gulp would do the transform itself but it doesn't seems so :\

The ugly but compatible version is to put the value of the constant as is, or try to use a gulp pluging to convert it to its literal value when creating the bundle. @mrdoob thoughts?

My fault, this is es2015 and it's supported in all the browsers, but on firefox we need to add extra parenthesis: [ (value) ]. I'll fix it

actually, on the latest version of nightly it works as expected :)

@mrdoob my fault, I was testing it incorrectly on firefox O:) it's working as expected in all the browsers, also tested on mobile (android & ios).

mrdoob · 2020-02-14T01:19:56Z

Closing this for now.

takahirox mentioned this pull request Aug 19, 2017

GLTFExporter #11951

Closed

87 tasks

mrdoob reviewed Aug 21, 2017

View reviewed changes

fernandojsg force-pushed the moveConstants branch 3 times, most recently from c23d6f5 to afe46fc Compare August 21, 2017 23:26

fernandojsg force-pushed the moveConstants branch 4 times, most recently from eb02143 to 7cfdced Compare August 23, 2017 22:40

fernandojsg force-pushed the moveConstants branch 2 times, most recently from 42771a7 to 7cfdced Compare August 23, 2017 22:47

fernandojsg force-pushed the moveConstants branch from 7cfdced to 2ff2690 Compare August 29, 2017 22:56

fernandojsg force-pushed the moveConstants branch 2 times, most recently from ab3400c to a8ac02d Compare September 4, 2017 17:56

mrdoob reviewed Oct 18, 2017

View reviewed changes

fernandojsg force-pushed the moveConstants branch 2 times, most recently from 9f60f23 to f9fb91b Compare October 20, 2017 09:41

fernandojsg added 7 commits October 20, 2017 11:41

Move WEBGL_CONSTANTS from GLTFExporter/Loader to WebGLConstants

cebc581

Move THREE_TO_WEBGL out from GLTFExporter

112dc79

Added WEBGL_TO_THREE mappings and apply it on GLTFLoader

d0645ef

Rename WEBGL_CONSTANTS to WebGLConstants

fa480fa

Moved fromGL and toGL to WebGLUtils

abfeaee

Replaced WebGLUtils.convert with toGL

03bbbd8

GLTFExporter: Rebased and fixed WebGLUtils use on the exporter

5f8ec00

fernandojsg force-pushed the moveConstants branch from f9fb91b to fe03d53 Compare October 20, 2017 09:41

Fixes few issues and rebased

bf090a6

fernandojsg force-pushed the moveConstants branch from fe03d53 to bf090a6 Compare October 20, 2017 09:44

donmccurdy mentioned this pull request Dec 26, 2018

GLTFLoader: exposing GLTFParser class and Constants #15477

Closed

mrdoob closed this Feb 14, 2020

fernandojsg deleted the moveConstants branch February 16, 2020 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move WEBGL_CONSTANTS and THREE_TO_WEBGL constants out from GLTFExporter and GLTFLoader #11978

Move WEBGL_CONSTANTS and THREE_TO_WEBGL constants out from GLTFExporter and GLTFLoader #11978

fernandojsg commented Aug 18, 2017

takahirox commented Aug 18, 2017

fernandojsg commented Aug 18, 2017 •

edited

Loading

takahirox commented Aug 18, 2017 •

edited

Loading

fernandojsg commented Aug 18, 2017

takahirox commented Aug 18, 2017

mrdoob Aug 21, 2017

fernandojsg Aug 21, 2017 •

edited

Loading

fernandojsg Aug 21, 2017

mrdoob Aug 21, 2017 •

edited

Loading

fernandojsg Aug 21, 2017

fernandojsg Aug 21, 2017

fernandojsg Aug 21, 2017

fernandojsg commented Aug 22, 2017

takahirox commented Aug 23, 2017 •

edited

Loading

fernandojsg commented Aug 23, 2017

fernandojsg commented Aug 24, 2017 •

edited

Loading

takahirox commented Aug 30, 2017

fernandojsg commented Aug 30, 2017

takahirox commented Oct 16, 2017

mrdoob Oct 18, 2017

fernandojsg Oct 18, 2017

mrdoob Oct 18, 2017

fernandojsg Oct 18, 2017

mrdoob Oct 18, 2017

fernandojsg Oct 18, 2017

mrdoob Oct 18, 2017

fernandojsg Oct 18, 2017

fernandojsg Oct 18, 2017

fernandojsg Oct 19, 2017

fernandojsg Oct 19, 2017

fernandojsg Oct 20, 2017

mrdoob commented Feb 14, 2020

Move WEBGL_CONSTANTS and THREE_TO_WEBGL constants out from GLTFExporter and GLTFLoader #11978

Move WEBGL_CONSTANTS and THREE_TO_WEBGL constants out from GLTFExporter and GLTFLoader #11978

Conversation

fernandojsg commented Aug 18, 2017

takahirox commented Aug 18, 2017

fernandojsg commented Aug 18, 2017 • edited Loading

takahirox commented Aug 18, 2017 • edited Loading

fernandojsg commented Aug 18, 2017

takahirox commented Aug 18, 2017

Choose a reason for hiding this comment

fernandojsg Aug 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrdoob Aug 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fernandojsg commented Aug 22, 2017

takahirox commented Aug 23, 2017 • edited Loading

fernandojsg commented Aug 23, 2017

fernandojsg commented Aug 24, 2017 • edited Loading

takahirox commented Aug 30, 2017

fernandojsg commented Aug 30, 2017

takahirox commented Oct 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrdoob commented Feb 14, 2020

fernandojsg commented Aug 18, 2017 •

edited

Loading

takahirox commented Aug 18, 2017 •

edited

Loading

fernandojsg Aug 21, 2017 •

edited

Loading

mrdoob Aug 21, 2017 •

edited

Loading

takahirox commented Aug 23, 2017 •

edited

Loading

fernandojsg commented Aug 24, 2017 •

edited

Loading