Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GLTF Skinning bug #10319

Merged
merged 1 commit into from
Dec 9, 2016
Merged

Fix GLTF Skinning bug #10319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/js/loaders/GLTFLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,13 @@ THREE.GLTFLoader = ( function () {

// So it goes like this:
// SkinnedMesh world matrix is already baked into MODELVIEW;
// ransform joints to local space,
// transform joints to local space,
// then transform using joint's inverse
m4v[ mi ]
.getInverse( boundUniform.sourceNode.matrixWorld )
.multiply( boundUniform.targetNode.skeleton.bones[ mi ].matrixWorld )
.multiply( boundUniform.targetNode.skeleton.boneInverses[ mi ] );
.multiply( boundUniform.targetNode.skeleton.boneInverses[ mi ] )
.multiply( boundUniform.targetNode.bindMatrix );

}

Expand Down