-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError: Window.createImageBitmap: 2 is not a valid argument count for any overload. #21003
Comments
so there is createImageBitmap fails when providing options object closed as a duplicate of Wrong results with UNPACK_FLIP_Y_WEBGL and createImageBitmap imageOrientation
which is still open after 4 years. not sure if you want to do anything about it. |
three.js/examples/js/loaders/GLTFLoader.js Lines 1846 to 1856 in 210c33f
|
a ha @Mugen87 that makes sense now. since FF fakes user agent and pretends to be an iPhone, this fails |
Closing then. |
FWIW, I have submitted patches to FF to add options support for createImageBitmap. Pending review on latest revision at the moment. |
@aardgoose 🙏🙏🙏 |
I was using the latest version of GLTFLoader and, inexplicably, a three.js app that was working fine previously on firefox 87.0 hit a snag with this error. I had to force the loader to use THREE.TextureLoader to get everything working again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Joshua3d can you create a jsfiddle that reproduces the issue? |
The createImageBitmap patches have now landed in Firefox nightly and the flipY and premulitplyAlpha options are supported. The gl.pixelStorei gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL and gl.UNPACK_FLIP_Y_WEBGL parameters are ignored as per latest spec. |
Nice! |
When do you think we'll be able to remove this code? three.js/examples/jsm/loaders/GLTFLoader.js Lines 2190 to 2200 in f058376
|
It's targeted for Firefox 93 due in early October unless it hits problems. |
Sometimes I get this error.
Steps to reproduce the behavior:
Code
Live example
n/a
Expected behavior
The error never happens
Screenshots
Platform:
The text was updated successfully, but these errors were encountered: