Skip to content

Commit

Permalink
Simplify nomenclature (#29093)
Browse files Browse the repository at this point in the history
  • Loading branch information
WestLangley authored Aug 9, 2024
1 parent 341e273 commit 7b69002
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion examples/jsm/shaders/OutputShader.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const OutputShader = {
#elif defined( CINEON_TONE_MAPPING )
gl_FragColor.rgb = OptimizedCineonToneMapping( gl_FragColor.rgb );
gl_FragColor.rgb = CineonToneMapping( gl_FragColor.rgb );
#elif defined( ACES_FILMIC_TONE_MAPPING )
Expand Down
6 changes: 3 additions & 3 deletions src/nodes/display/ToneMappingNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ const ReinhardToneMappingNode = Fn( ( { color, exposure } ) => {
} );

// source: http://filmicworlds.com/blog/filmic-tonemapping-operators/
const OptimizedCineonToneMappingNode = Fn( ( { color, exposure } ) => {
const CineonToneMappingNode = Fn( ( { color, exposure } ) => {

// optimized filmic operator by Jim Hejl and Richard Burgess-Dawson
// filmic operator by Jim Hejl and Richard Burgess-Dawson
color = color.mul( exposure );
color = color.sub( 0.004 ).max( 0.0 );

Expand Down Expand Up @@ -159,7 +159,7 @@ const NeutralToneMappingNode = Fn( ( { color, exposure } ) => {
const toneMappingLib = {
[ LinearToneMapping ]: LinearToneMappingNode,
[ ReinhardToneMapping ]: ReinhardToneMappingNode,
[ CineonToneMapping ]: OptimizedCineonToneMappingNode,
[ CineonToneMapping ]: CineonToneMappingNode,
[ ACESFilmicToneMapping ]: ACESFilmicToneMappingNode,
[ AgXToneMapping ]: AgXToneMappingNode,
[ NeutralToneMapping ]: NeutralToneMappingNode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ vec3 ReinhardToneMapping( vec3 color ) {
}
// source: http://filmicworlds.com/blog/filmic-tonemapping-operators/
vec3 OptimizedCineonToneMapping( vec3 color ) {
vec3 CineonToneMapping( vec3 color ) {
// optimized filmic operator by Jim Hejl and Richard Burgess-Dawson
// filmic operator by Jim Hejl and Richard Burgess-Dawson
color *= toneMappingExposure;
color = max( vec3( 0.0 ), color - 0.004 );
return pow( ( color * ( 6.2 * color + 0.5 ) ) / ( color * ( 6.2 * color + 1.7 ) + 0.06 ), vec3( 2.2 ) );
Expand Down
2 changes: 1 addition & 1 deletion src/renderers/webgl/WebGLProgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function getToneMappingFunction( functionName, toneMapping ) {
break;

case CineonToneMapping:
toneMappingName = 'OptimizedCineon';
toneMappingName = 'Cineon';
break;

case ACESFilmicToneMapping:
Expand Down

0 comments on commit 7b69002

Please sign in to comment.