WebGLObjects: Optimize InstancedMesh updates. (#26300)

* WebGLObjects: Optimize `InstancedMesh` updates. * Skeleton: Clean up.
mrdoob · Jun 20, 2023 · 7b419c9 · 7b419c9
1 parent 356d648
commit 7b419c9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/src/objects/Skeleton.js b/src/objects/Skeleton.js
@@ -23,8 +23,6 @@ class Skeleton {
 		this.boneTexture = null;
 		this.boneTextureSize = 0;
 
-		this.frame = - 1;
-
 		this.init();
 
 	}

diff --git a/src/renderers/webgl/WebGLObjects.js b/src/renderers/webgl/WebGLObjects.js
@@ -27,22 +27,31 @@ function WebGLObjects( gl, geometries, attributes, info ) {
 
 			}
 
-			attributes.update( object.instanceMatrix, gl.ARRAY_BUFFER );
+			if ( updateMap.get( object ) !== frame ) {
 
-			if ( object.instanceColor !== null ) {
+				attributes.update( object.instanceMatrix, gl.ARRAY_BUFFER );
 
-				attributes.update( object.instanceColor, gl.ARRAY_BUFFER );
+				if ( object.instanceColor !== null ) {
+
+					attributes.update( object.instanceColor, gl.ARRAY_BUFFER );
+
+				}
+
+				updateMap.set( object, frame );
 
 			}
 
 		}
 
 		if ( object.isSkinnedMesh ) {
 
-			if ( object.skeleton.frame !== info.render.frame ) {
+			const skeleton = object.skeleton;
+
+			if ( updateMap.get( skeleton ) !== frame ) {
+
+				skeleton.update();
 
-				object.skeleton.update();
-				object.skeleton.frame = info.render.frame;
+				updateMap.set( skeleton, frame );
 
 			}