Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't set deprecated allFeatures setting by default #424

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

zjp-CN
Copy link
Contributor

@zjp-CN zjp-CN commented Jun 15, 2024

The allFeatures setting is disabled by RA, and deprecated for two year.

ref: rust-lang/rust-analyzer#17371 (comment)

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.
  • Updated CHANGELOG.md

@zjp-CN zjp-CN changed the title remove allFeatures setting chore: remove allFeatures setting Jun 15, 2024
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks 🙏

@mrcjkb mrcjkb changed the title chore: remove allFeatures setting fix: don't set deprecated allFeatures setting by default Jun 15, 2024
@mrcjkb mrcjkb enabled auto-merge (squash) June 15, 2024 09:48
@mrcjkb mrcjkb disabled auto-merge June 15, 2024 09:48
@mrcjkb mrcjkb merged commit 66b888c into mrcjkb:master Jun 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants