This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
fix: set containerPort to targetPort if defined #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`containerPort` gets set to the template `port`, and `targetPort` is
ignored even when defined. This causes an issue where `port` actually
points to the external ClusterIP port, and the `targetPort` is the port
where the service is exposed from the container. Hence, in the case
where `targetPort` is defined, `containerPort` should be set to
`targetPort` and not the external ClusterIP port.
eg: defining ports in kubekutr config like:
```
ports:
- port: 9000 # external cluster IP port
targetPort: 8000 # actual internal container port
```
sets the containerPort to `9000` instead of `8000`, which is wrong in
this case because `9000` is the port which is exposed to the cluster,
and `8000` is the port that the container is supposed to expose.
Signed-off-by: Chinmay D. Pai <[email protected]>
mr-karan
reviewed
Nov 26, 2020
Signed-off-by: Chinmay D. Pai <[email protected]>
Signed-off-by: Chinmay D. Pai <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerPortgets set to the templateport, andtargetPortis ignored even when defined. This causes an issue whereportactually points to the external ClusterIP port, and thetargetPortis the port where the service is exposed from the container. Hence, in the case wheretargetPortis defined,containerPortshould be set totargetPortand not the external ClusterIP port.eg: defining ports in kubekutr config like:
sets the containerPort to
9000instead of8000, which is wrong in this case because9000is the port which is exposed to the cluster, and8000is the port that the container is supposed to expose.