feat: Dont set defaults for resource limits

Setting a default value isn't ideal. Causes unsuspecting OOM, high latencies due to CPU throttling etc.
mr-karan · Nov 27, 2020 · 29a01f2 · 29a01f2
1 parent 0da6f2b
commit 29a01f2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/templates/containers.tmpl b/templates/containers.tmpl
@@ -17,11 +17,11 @@
         {{- end}}
         resources:
           requests:
-            memory: {{- if .RequestsMemory }} {{.RequestsMemory}} {{- else }} 128Mi {{- end}}
-            cpu: {{- if .RequestsCPU }} {{.RequestsCPU}} {{- else }} 250m {{- end}}
+            memory: {{- if .RequestsMemory }} {{.RequestsMemory}}
+            cpu: {{- if .RequestsCPU }} {{.RequestsCPU}}
           limits:
-            memory: {{- if .LimitsMemory }} {{.LimitsMemory}} {{- else }} 256Mi {{- end}}
-            cpu: {{- if .LimitsCPU }} {{.LimitsCPU}} {{- else }} 500m {{- end}}
+            memory: {{- if .LimitsMemory }} {{.LimitsMemory}}
+            cpu: {{- if .LimitsCPU }} {{.LimitsCPU}}
         {{- if .ReadinessProbePort}}
         readinessProbe:
           httpGet: