This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
support structure of bower.json #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bower.json top level keys may include name, version and other keys we don't care about. We really only care about the dependency key. So limit our search to that, if it's there. Else bower-meteor will throw errors like "expected 'name' to have a version string", which of course it won't
|
I don't have access to a computer this weekend, but I'll review your PR when I'm back home. |
mquandalle
added a commit
that referenced
this pull request
Apr 14, 2014
Support structure of bower.json
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bower.json top level keys may include name, version and other keys we don't care about. We really only care about the dependency key. So limit our search to that, if it's there. Else bower-meteor will throw errors like "expected 'name' to have a version string", which of course it won't.
Let me know if there's anything I can do to clean this PR up for acceptance, or if I missed something (I'm new to writing Meteor plugins but I think I understand this plugin enough to be confident about my change, unless I'm misreading the code somewhat.)