Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZipArchives to v2 #2

Merged
merged 4 commits into from
Aug 31, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Aug 14, 2024

I am no longer supporting ZipArchives v1, so it would be good to update to v2 to get bug fixes I made and avoid compat issues like JuliaIO/ZipArchives.jl#60.

@nhz2
Copy link
Contributor Author

nhz2 commented Aug 27, 2024

Bump

@jonas-schulze
Copy link
Member

Hi @nhz2, sorry for the late response. I didn't configure my notifications properly. 🙈

I had internally tested both versions of ZipArchives, but decided for v1 because I also needed MatrixMarket v0.5 (ERROR: Unsatisfiable requirements detected for package TranscodingStreams). However, thanks to your recent PR (JuliaSparse/MatrixMarket.jl#58) this no longer is an issue. 🚀

Thanks for the contribution! I'll update the changelog and prepare a release.

@jonas-schulze jonas-schulze merged commit cf7f37d into mpimd-csc:main Aug 31, 2024
@nhz2
Copy link
Contributor Author

nhz2 commented Aug 31, 2024

Thank you for updating. ZipArchives.jl should be stable in the future.

@nhz2 nhz2 deleted the update-to-ZipArchives-2 branch August 31, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants