feat: Enabled by default visibility of extension pages and content scripts logs in the BrowserConsole

[rbrishabh]

Fixes #1702

Hey @rpl!

I hope you're doing well!

I believe this is the only change that is needed to fix this issue. Is that right?

Also, do I need to use a conditional statement to only set extensions.logging.enabled to true when --browser-console is sent as a parameter when running web-ext?

Thanks!

[coveralls]

Coverage remained the same at 100.0% when pulling c96a0dc on rbrishabh:issue-console into 5be19b0 on mozilla:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 23a2aec on rbrishabh:issue-console into 5be19b0 on mozilla:master.

[rbrishabh]

Ahh! Since I didn't find devtools.browserconsole.contentMessages, I assumed I was supposed to look for something similar for logging considering the issue summary of #1702 as just a pointer to the kind of change you might want to make.

Anyways, I made the change in preferences.js now.

Please review this again and let me know what you think.
Thanks!

@rpl

[rbrishabh]

Hey @rpl, could you find any time to look into this?

Thanks!

[rpl]

@rbrishabh Thanks, it looks good and works as expected.

Also, do I need to use a conditional statement to only set extensions.logging.enabled to true when --browser-console is sent as a parameter when running web-ext?

I wouldn't bother to "only enabling it when --browser-console option is also passed to web-ext run", as an extension developer I would prefer it to be enabled by default to ensure that if I open the Browser Console manually (without using the --browser-console option) I'm still going to see the extension logs without having to find out the option and enabled it manually (the option can be toggle from the gear icon in the top-right corner of the Browser Console, but I think that it is quite easy to miss to notice it).

If we experience issues related to that preference we may re-evaluate this choice in a separate follow up.

In the meantime, thanks for the PR! I'm going to merge right now \o/