Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nsp check errors on travis (related to open, sign-addon and fx-runner) #1323

Merged
merged 3 commits into from
May 23, 2018

Conversation

rpl
Copy link
Member

@rpl rpl commented May 23, 2018

This PR updates the npm dependencies that are currently detected by nsp check as potential vulnerabilities
(which makes every travis job to fail before running any actual test).

This PR also contains the patch from #1319 with just two small changes:

  • the exact version on the opn dependency (needed so that greenkeeper can create PR once new versions of that package are released on npm)
  • small change on the commit message (so that i follows conventional-changelog conventions)

On top of that patch this PR also updates:

  • fx-runner to version 1.0.9 (which fixes the nsp check errors related to lodash)
  • sign-addon to version 0.3.1 (which fixes nsp check/npm audit errors related to hoek)

@coveralls
Copy link

coveralls commented May 23, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 299a936 on rpl:fix/nsp-check-errors-20180523 into 0865b9f on mozilla:master.

@rpl rpl changed the title Fix: nsp check errors on travis (related to open, sign-addon and fx-runner) fix: nsp check errors on travis (related to open, sign-addon and fx-runner) May 23, 2018
@rpl rpl mentioned this pull request May 23, 2018
@rpl
Copy link
Member Author

rpl commented May 23, 2018

Besides being finally back to green on travis (yay! \o/), I also manually verified locally that the docs, run and sign commands are working correctly with the updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants