This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
Adapt to the revised data channel API that landed in FF22. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var localPort = randomPort(); | ||
| var remotePort = randomPort(); | ||
| while (remotePort == localPort) // Avoid being extremely unlucky... | ||
| remotePort = randomPort(); |
There was a problem hiding this comment.
I'm glad we can finally get rid of this awful hack :-)
|
Looks good to me. My only concern is that the existing android builds we have will no longer work with this landed, and I heard that webrtc doesn't work well on newer android builds. |
|
WebRTC is now built by default, and last I heard works reasonably well, and improving, though maybe not to quite the same quality just yet, but near. I'm not sure we need to worry about that here though as the old builds aren't really public anyway. |
Standard8
added a commit
that referenced
this pull request
May 13, 2013
Adapt to the revised data channel API that landed in FF22.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://mozilla.github.io/webrtc-landing/DataChannel_changes.html for info about the changes.