This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
Make chat more usable during audio only calls. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard8
added a commit
that referenced
this pull request
Mar 6, 2013
Make chat more usable during audio only calls.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending an audio+video offer, if the answer contains audio only, then the data channel isn't reliably established for some reason, so I would recommend that someone demoing chat ensures that the call is started as audio-only.
Otherwise things seem to be in good shape for a chat demo.
I didn't find a clean CSS way to make the chat area take all the available vertical space on the mobile page, so I have hardcoded height values that fit well for the Nexus 4 (there's a media query, with one value for landscape and one for portrait mode; both modes should be usable for a chat demo).