This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
chore(package): update request to version 2.79.0 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the following deprecation warning upon `npm install`:
npm WARN deprecated [email protected]: use uuid module instead
`request` switched from `node-uuid` to `uuid` in version 2.79.0:
request/request@263e16e
|
Thanks |
|
Sure thing, thanks for the quick merge! Any chance you could release version 0.2.1? It'd be nice to get web-ext upgraded. |
josephfrazier
added a commit
to josephfrazier/browser-extension
that referenced
this pull request
Jan 28, 2017
This avoids the following deprecation warning upon `npm install`:
npm WARN deprecated [email protected]: use uuid module instead
`web-ext` still uses `node-uuid` indirectly (via `sign-addon` -> `request`),
but I'm working on fixing that too. See mozilla/sign-addon#245
|
Sure, I can release sign-addon on Monday. We'll cut a web-ext release after this gets merged: mozilla/web-ext#753 |
stefanbuck
pushed a commit
to OctoLinker/OctoLinker
that referenced
this pull request
Jan 28, 2017
This avoids the following deprecation warning upon `npm install`:
npm WARN deprecated [email protected]: use uuid module instead
`web-ext` still uses `node-uuid` indirectly (via `sign-addon` -> `request`),
but I'm working on fixing that too. See mozilla/sign-addon#245
|
Great to hear, thanks again! |
|
Thanks, @josephfrazier! Your contribution has been added to our recognition wiki. Welcome onboard! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the following deprecation warning upon
npm install:requestswitched fromnode-uuidtouuidin version 2.79.0:request/request@263e16e