cache assets #516
cache assets #516
Conversation
package.json
Outdated
| @@ -99,13 +106,12 @@ | |||
| ], | |||
| "scripts": { | |||
| "precommit": "lint-staged", | |||
| "clean": "rm -rf dist", | |||
There was a problem hiding this comment.
This may or may not work on Windows. Can't remember if we need rimraf for cross-OS compatibility.
webpack.config.js
Outdated
| } | ||
| ]), | ||
| new HtmlPlugin({ | ||
| filename: '../views/index.handlebars', |
There was a problem hiding this comment.
Should we just rename all the ../views/*.handlebars to *.hbs, for consistency?
There was a problem hiding this comment.
I kinda went this way to distinguish between the two
webpack/download.hbs
Outdated
|
|
||
| <script src="/jsconfig.js"></script> | ||
| <script src="/polyfill.min.js"></script> | ||
| <script defer src="/l20n.min.js"></script> |
There was a problem hiding this comment.
Do these 3 <script> tags need to be in the <head>, or can we move them to the end of the <body> tag? In my very unscientific testing, this had a decent sized performance improvement when testing locally using Lighthouse, but that isn't always a great measure.
There was a problem hiding this comment.
They shouldn't need to be in the head. worth a shot
webpack/legal.hbs
Outdated
| @@ -0,0 +1,71 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
These files have a fair amount of boilerplate now, w/ header and footer.
There was a problem hiding this comment.
yeah... I'm gonna try to bring back the main layout
dannycoates
force-pushed
the
cache-assets
branch
5 times, most recently
from
d0689e3 to
faf2f6a
Compare
dannycoates
force-pushed
the
cache-assets
branch
4 times, most recently
from
18af2ff to
a947334
Compare
dannycoates
force-pushed
the
cache-assets
branch
from
a947334 to
757ac14
Compare
I have no idea what I'm doing!
...but it works.
fixes #389