Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

make the site mostly work when cookies (localStorage) are disabled #492

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

dannycoates
Copy link
Contributor

In Firefox when cookies are disabled so is localStorage. The current version 1.1.0 is completely unusable when this is set and I've noticed a few related errors on sentry.

This PR makes uploading and downloading work, but the file list (as expected) does not.

@pdehaan
Copy link
Contributor

pdehaan commented Aug 10, 2017

Q: Should we display some notification about "enhanced" file list functionality when a user has cookies disabled?

@dannycoates
Copy link
Contributor Author

Should we display some notification about "enhanced" file list functionality when a user has cookies disabled?

I think this would be a good follow-up issue for UX. There's other scenarios where localStorage isn't available as well. The one I'm thinking of is Firefox Focus. In that particular case maybe we want to assume the user doesn't expect to be able to see upload history at all, so notifying them would just be annoying?

@dannycoates
Copy link
Contributor Author

Speaking of Focus, this PR makes uploading work for me on Focus for iOS, but download is still broken.

@dannycoates dannycoates merged commit 0fa0416 into master Aug 10, 2017
@dannycoates dannycoates deleted the no-cookies branch August 14, 2017 00:13
@ehuggett
Copy link
Contributor

As the fallback storage eventually falls back to "map()" i presume this causes more issues as the file gets larger? (up to the point were it is unusable due to the memory consumption or the browser actually won't allow it)

From a quick search it appears to be possible to read a local file in memory in "chunks", which could be encrypted and uploaded before loading the next one. Files would presumably have to be uploaded slightly differently to accommodate this (or can you append data onto a HTTP post that is already in-progress? I assume not, so multiple POST's/etc)

The idea came from #174

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants