-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Generate production locales using 'compare-locales' #367
Conversation
awesome! Should we add this to the circle build? |
I have no idea when/if we want this. It almost feels weird to do this "arbitrary" decision in CI. I'm still trying to understand the implications, so I'd lean more towards managing these somewhat manually, so we have a hand-crafted, organic, artisanal selection of available locales. I think the problem is that if one of us adds a new string, then commits it to en-US, all locales would fall to 99% and then be excluded from stage/prod until the localizers added that one missing string. |
Plus, this step requires |
@@ -46,40 +46,38 @@ | |||
"license": "MPL-2.0", | |||
"repository": "mozilla/send", | |||
"availableLanguages": [ | |||
"en-US", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannycoates Are these available languages in a "specific" order? I think my script just blindly A-z the locales, but wasn't sure if having "en-US" at the front is important, or if it serves as a fallback locale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, they're in the order the pontoon ui puts them. a-z is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, why not!
You can get the latest production locales (100% translations, zero errors) with
npm run get-prod-locales
or you can overwrite the package.jsonavailableLanguages
array withnpm run get-prod-locales -- --write
. We could make that a bit prettier by wrapping in another npm script, but hey...Fixes #357
Fixes #364