Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeRegexp should only call ScriptRuntime.addInstructionCount when instruction counting is enabled (issue #1497) #1498

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Jun 20, 2024

and some code improvments suggested by idea

Closes #1497

@rbri
Copy link
Collaborator Author

rbri commented Jun 29, 2024

@gbrail / @p-bakker can i merge this?

@gbrail
Copy link
Collaborator

gbrail commented Jun 30, 2024

Yes, looks good and I will merge it. Thanks!

@gbrail gbrail merged commit 91319de into mozilla:master Jun 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.7.15: NativeRegexp calls ScriptRuntime.addInstructionCount when instruction counting is not enabled
2 participants