Fix unhandled promise rejection handler after a .then
#1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a promise `p1` that is rejected, and invoke `then` on it, we create a new promise `p2` (as it should be, per the spec) and mark `p1` as handled. However, if we call `.catch` on `p2`, we are _not_ marking `p1` as handled correctly since its status is "pending" and not "rejected". This patch fixes it and adds some tests. Fixes mozilla#1461
|
LGTM thanks a lot for this contribution |
|
Thanks -- I agree that it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a promise
p1that is rejected, and invokethenon it, we create a new promisep2(as it should be, per the spec) and markp1as handled. However, if we call.catchonp2, we are not markingp1as handled correctly since its status is "pending" and not "rejected". This patch fixes it and adds some tests.Fixes #1461