Closes #537: Port datasource URL code to an extension. #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
No surprises here, other than we'll need to move the configuration_properties feature to upstream ASAP.
I think it's okay to make this change here since we'll need to merge this with d9c59f4 anyway at the next rebase.
Looking at that commit, would you say that porting the datasource version feature in d9c59f4 would be the next logical step?
|
@jezdez Thank you for the review! Indeed, I already have a PR almost ready for datasource version! I'll be opening up a PR upstream for |
|
@emtwo Awesome, thank you again for your diligence 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is removing the code from this changeset: 75228b2
And using the new datasource url extension here: mozilla/redash-stmo@c4a45de