Implements shading types 4-7 #4192
Conversation
|
@yurydelendik This patch fixes a lot of the mentioned issues! There is still a problem with (for example) #2922 which uses tiling type 1. I'm not sure whether or not you are going to implement tiling types 4, 5, 6 and 7 or also 1, 2 and 3, but I thought I would just mention this. Great work! |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a2a6295988a73d2/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a2a6295988a73d2/output.txt Total script time: 0.22 mins Published
|
tiling is not connected with shading operation, will not be addressed by this pr (if we have tags assigned improperly, we need to fix that) |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/1d31560e3d4c9ab/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/1d31560e3d4c9ab/output.txt Total script time: 38.05 mins
Image differences available at: http://107.22.172.223:8877/1d31560e3d4c9ab/reftest-analyzer.xhtml#web=eq.log |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/41372d99aafffe4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/cb558dc29b4c8cc/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/41372d99aafffe4/output.txt Total script time: 19.36 mins
Image differences available at: http://107.21.233.14:8877/41372d99aafffe4/reftest-analyzer.xhtml#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/cb558dc29b4c8cc/output.txt Total script time: 38.27 mins
Image differences available at: http://107.22.172.223:8877/cb558dc29b4c8cc/reftest-analyzer.xhtml#web=eq.log |
|
Looks like there are a few issues with http://www.tcpdf.org/examples/example_030.pdf (probably a good test pdf to add). |
|
@brendandahl let's open as follow up issue for example_030.pdf -- something weird is happening on the second page. (even Mac's Preview hangs there) I'll probably have to read a spec between the lines. |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/005f46e433ca48f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/6e3a4fcda24c3df/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/005f46e433ca48f/output.txt Total script time: 24.22 mins
Image differences available at: http://107.21.233.14:8877/005f46e433ca48f/reftest-analyzer.xhtml#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/21498ca28dc229d/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/21498ca28dc229d/output.txt Total script time: 38.72 mins
Image differences available at: http://107.22.172.223:8877/21498ca28dc229d/reftest-analyzer.xhtml#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fb3e50702d80c4e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/f9a22f188e97cbd/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/fb3e50702d80c4e/output.txt Total script time: 23.91 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/f9a22f188e97cbd/output.txt Total script time: 37.48 mins
|
Implements shading types 4-7
|
Bugzilla issues:
|
(list of issues https://github.com/mozilla/pdf.js/issues?labels=4-shading-pattern&page=1&state=open and https://bugzilla.mozilla.org/buglist.cgi?quicksearch=d-shading-pattern&list_id=9290423)
TODO:
[x] land Refactors shared/pattern.js into core/ and display/ #4189 and rebase[x] invert picture (see Unsupported shading type: 4 #2948)[x] type 6 (see PDF Fails to Render #1950)