[api-minor] Remove the default-factories from the viewer components (PR 15811 follow-up) #16592
Conversation
…PR 15811 follow-up) The changes in PR 15811 have now been included in no less than six official releases, hence it should hopefully be OK to remove this now.
…s the expected functionality Until now we've not actually had *any* tests that ensure that the *official* PDF.js-viewer API exposes the intended functionality, which means that things can easily break accidentally. *Please note:* This unit-test cannot (easily) be run in Node.js-environments, since the `external/webL10n/l10n.js` file contains various browser-specific functionality.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
| /* eslint-disable-next-line no-unused-vars */ | ||
| const pdfjsVersion = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| const pdfjsVersion = | ||
| typeof PDFJSDev !== "undefined" ? PDFJSDev.eval("BUNDLE_VERSION") : void 0; | ||
| /* eslint-disable-next-line no-unused-vars */ | ||
| const pdfjsBuild = |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b8b817bff04d70f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/99d2dfcc23e4904/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b8b817bff04d70f/output.txt Total script time: 2.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/99d2dfcc23e4904/output.txt Total script time: 11.28 mins
|
|
Looks good! |
The changes in PR #15811 have now been included in no less than six official releases, hence it should hopefully be OK to remove this now.