Always parse the entire startXRefQueue in XRef.readXRef (issue 15833)
#15834
Conversation
…833) Previously we'd abort all parsing if an Error was encountered, despite the fact that multiple `startXRefQueue`-entries may be available and that continued parsing could thus eventually be able to find usable data. Note that in the referenced PDF document the `startxref`-operator, at the end of the file, points to a position in the middle of an arbitrary `stream` which is why things break.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/ed0cc0a0bd0fda9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/2ecdf815c0489ce/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ed0cc0a0bd0fda9/output.txt Total script time: 25.51 mins
Image differences available at: http://54.241.84.105:8877/ed0cc0a0bd0fda9/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2ecdf815c0489ce/output.txt Total script time: 26.32 mins
Image differences available at: http://54.193.163.58:8877/2ecdf815c0489ce/reftest-analyzer.html#web=eq.log |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/68dee5f82cf2ebd/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3c9da1a09aea195/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3c9da1a09aea195/output.txt Total script time: 4.25 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/68dee5f82cf2ebd/output.txt Total script time: 11.65 mins
|
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f6c394e21cd2443/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/809261b5e5c3b91/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f6c394e21cd2443/output.txt Total script time: 21.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/809261b5e5c3b91/output.txt Total script time: 23.57 mins
|
Previously we'd abort all parsing if an Error was encountered, despite the fact that multiple
startXRefQueue-entries may be available and that continued parsing could thus eventually be able to find usable data.Note that in the referenced PDF document the
startxref-operator, at the end of the file, points to a position in the middle of an arbitrarystreamwhich is why things break.