Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle possibly undefined parameters *once* per AnnotationLayer.render invocation #15824

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Handle possibly undefined parameters *once* per AnnotationLayer.render invocation #15824

merged 1 commit into from
Dec 14, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

There's no reason to repeat this for every single annotation. Also, adds a couple of missing JSDoc-parameters.

@Snuffleupagus
Copy link
Collaborator Author

Split out from PR #15811, to reduce its size ever so slightly.

/botio test

@Snuffleupagus
Handle possibly undefined parameters *once* per `AnnotationLayer.rend…
dcf9ff2 
…er` invocation

There's no reason to repeat this for every single annotation. Also, adds a couple of missing JSDoc-parameters.
calixteman
calixteman approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/41c59756ba9231a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9449922da7f44cb/output.txt

@mozilla mozilla deleted a comment from pdfjsbot Dec 14, 2022
@mozilla mozilla deleted a comment from pdfjsbot Dec 14, 2022
@mozilla mozilla deleted a comment from pdfjsbot Dec 14, 2022
@mozilla mozilla deleted a comment from pdfjsbot Dec 14, 2022
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/41c59756ba9231a/output.txt

Total script time: 25.76 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/41c59756ba9231a/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9449922da7f44cb/output.txt

Total script time: 31.86 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/9449922da7f44cb/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit d90e62e into mozilla:master Dec 14, 2022
@Snuffleupagus Snuffleupagus deleted the annotationLayer-params branch December 14, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @pdfjsbot @calixteman