Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fallback for non-embedded *composite* Tahoma fonts (issue 15719) #15732

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Add a fallback for non-embedded *composite* Tahoma fonts (issue 15719) #15732

merged 1 commit into from
Nov 24, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

No description provided.

@Snuffleupagus Snuffleupagus linked an issue Nov 23, 2022 that may be closed by this pull request
Some PDF with Hebrew content doesnot display correctly #15719
Closed
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e5c13a062974403/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/85251fc582f57d4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e5c13a062974403/output.txt

Total script time: 25.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/e5c13a062974403/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/85251fc582f57d4/output.txt

Total script time: 33.17 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 15

Image differences available at: http://54.193.163.58:8877/85251fc582f57d4/reftest-analyzer.html#web=eq.log

calixteman
calixteman approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus Snuffleupagus merged commit 8fda3f0 into mozilla:master Nov 24, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/abcb3a4a07177a1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/c1c55184f288275/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/abcb3a4a07177a1/output.txt

Total script time: 21.64 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/c1c55184f288275/output.txt

Total script time: 25.29 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-15719 branch November 24, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
font-conversion non-standard-fonts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some PDF with Hebrew content doesnot display correctly
3 participants
@Snuffleupagus @pdfjsbot @calixteman